Skip to content

refactor(sdk-python): hoist HTTPX network error names in exception converter #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gujiassh wants to merge 1 commit into from
Closed

refactor(sdk-python): hoist HTTPX network error names in exception converter #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions sdks/sandbox/python/src/opensandbox/adapters/converter/exception_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@

logger = logging.getLogger(__name__)

HTTPX_NETWORK_ERROR_TYPES = {
"ConnectError",
"TimeoutException",
"NetworkError",
"ReadTimeout",
"WriteTimeout",
}


class ExceptionConverter:
"""
Expand Down Expand Up @@ -134,14 +142,7 @@ def _is_httpx_status_error(e: Exception) -> bool:

def _is_httpx_network_error(e: Exception) -> bool:
"""Check if exception is an httpx network-related error."""
error_types = (
"ConnectError",
"TimeoutException",
"NetworkError",
"ReadTimeout",
"WriteTimeout",
)
return type(e).__name__ in error_types
return type(e).__name__ in HTTPX_NETWORK_ERROR_TYPES


def _convert_unexpected_status_to_api_exception(e: Exception) -> SandboxApiException:
Expand Down