docs(osep): add OSEP-0005 for developer console with phased auth model (#348)#351
docs(osep): add OSEP-0005 for developer console with phased auth model (#348)#351divyamagrawal06 wants to merge 4 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds OSEP-0005 documentation proposing a Developer Console for sandbox lifecycle operations and a phased authentication/authorization model (Phase 1: trusted headers + metadata scoping; Phase 2: OIDC/JWT + PostgreSQL RBAC/audit).
Changes:
- Introduces a new OSEP document defining MVP console scope and server-side RBAC enforcement without a database.
- Documents Phase 2 hardening plan (OIDC/JWT validation, PostgreSQL RBAC bindings, durable audit).
- Adds rollout, risks/mitigations, and test plan sections to guide implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b98977f0c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
23edc57 to
1dd42fd
Compare
|
@jwx0925 resolved codex comments, please review |
reviewing on it |
|
Suggestion: clarify authentication failure behavior for trusted-header mode The proposal explains how identity headers are configured for the trusted-header user auth path, but it does not explicitly describe the authentication failure behavior when those headers are missing. In practice this can happen if:
It would be helpful to explicitly specify what the server should do in this case. For example: When auth.mode = "api_key_and_user" and user_mode = "trusted_header", requests intended for Console access that do not contain the configured trusted headers should be treated as unauthenticated and rejected (e.g. 401 Unauthorized). The Console should then render a clear authentication-required or proxy-misconfiguration screen rather than silently falling back to anonymous access or another auth path. Making this behavior explicit would remove ambiguity in the Phase 1 design and help operators understand the expected deployment model for trusted-header authentication. |
|
@jwx0925 Updated. I've edited the OSEP to state that when |
Summary
oseps/0005-developer-console-phased-auth-model.mdas the design proposal for issue feat: add developer console for sandbox operations with phased auth model #348.console/React app for sandbox list/detail/create/renew/delete/endpoint flowsread_onlyvsoperator)OPEN-SANDBOX-API-KEYautomation and SDKworkflows.
Testing
Breaking Changes
Checklist
#348)