fix(server): proxy websocket sandbox routes#388
Open
liuxiaopai-ai wants to merge 1 commit intoalibaba:mainfrom
Open
fix(server): proxy websocket sandbox routes#388liuxiaopai-ai wants to merge 1 commit intoalibaba:mainfrom
liuxiaopai-ai wants to merge 1 commit intoalibaba:mainfrom
Conversation
Contributor
Author
|
@ninan-nn @Pangjiping This should fix issue #383. Could you please take a look when you have a moment? Thanks! |
Collaborator
Thanks for this, I will review this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sandboxes/{id}/proxy/{port}and nested pathsuse_server_proxy=trueRoot cause
Issue #383 is real. The server proxy only registered HTTP routes and explicitly treated websocket upgrades as unsupported, so browser websocket handshakes never reached the sandbox backend. Separately,
get_endpoint(..., use_server_proxy=true)returned/proxy/{port}but the server only handled/proxy/{port}/{full_path}.Testing
cd server && uv run pytest tests/test_routes_proxy.pycd server && uv run pytest tests/test_routes*.pycd server && uv run pyright src/api/lifecycle.py tests/test_routes_proxy.pycd server && uv run ruff check src/api/lifecycle.py tests/test_routes_proxy.pyFixes #383