feat(sandbox): add terminal settings support for create_session API#541
Open
xdlkc wants to merge 3 commits intoalibaba:masterfrom
Open
feat(sandbox): add terminal settings support for create_session API#541xdlkc wants to merge 3 commits intoalibaba:masterfrom
xdlkc wants to merge 3 commits intoalibaba:masterfrom
Conversation
|
|
xdlkc
force-pushed
the
feat/terminal-settings
branch
from
4fb32c4 to
d162136
Compare
xdlkc
force-pushed
the
feat/terminal-settings
branch
from
d162136 to
7c39e67
Compare
Changed term and lang parameters to optional (str | None) with None as default. This maintains backward compatibility by not setting TERM and LANG environment variables unless explicitly specified by the user. Key changes: - term: str | None = None (was str = "dumb") - lang: str | None = None (was str = "en_US.UTF-8") - columns/lines: unchanged (default 80/24 for pexpect dimensions) - Only set TERM/LANG env vars when user explicitly provides values - Reverted _strip_control_chars to original (no \r stripping) - Updated tests to reflect new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateBashSessionRequest:term: terminal type (default:dumb)columns: terminal width (default:80)lines: terminal height (default:24)lang: language/encoding (default:en_US.UTF-8)Problem
When `env_enable=False` (default), bash sessions lack terminal environment variables, causing:
Solution
Priority: `env` param > terminal params > inherited env > defaults
Test Plan
fixes #540