Skip to content

add enable_remove_container config #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Issac-Newton merged 2 commits into from
Mar 10, 2026
Merged

add enable_remove_container config #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db878f1
add enable_remove_container config
Issac-Newton Mar 9, 2026
fe1c7f0
rename: enable_remove_container to remove_container_enabled
Issac-Newton Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rock/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class SandboxConfig:
actor_resource: str = ""
actor_resource_num: float = 0.0
gateway_num: int = 1
remove_container_enabled: bool = True


@dataclass
Expand Down
1 change: 1 addition & 0 deletions rock/deployments/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ async def init_config(self, config: DeploymentConfig) -> DockerDeploymentConfig:
await self.rock_config.update()
docker_deployment_config.actor_resource = self.rock_config.sandbox_config.actor_resource
docker_deployment_config.actor_resource_num = self.rock_config.sandbox_config.actor_resource_num
docker_deployment_config.remove_container = self.rock_config.sandbox_config.remove_container_enabled
return docker_deployment_config

def get_deployment(self, config: DeploymentConfig) -> AbstractDeployment:
Expand Down
Loading