Feature/remove container#608
Closed
Issac-Newton wants to merge 11 commits intoalibaba:release/v1.3from
Closed
Conversation
…libaba#571) * support create standard_spec sandbox * rename enforce_standard_spec to use_standard_spec_only
…t retrieval script (alibaba#581) * feat: update the parameter passing in the CI trigger script and result retrieval script * feat: update the parameter passing in the CI trigger script and result retrieval script
- Add /sandboxes/{id}/portforward WebSocket endpoint in proxy layer
- Add /portforward WebSocket endpoint in rocklet for internal TCP proxy
- Support port range 1024-65535, excluding port 22 (SSH)
- Implement two-layer architecture: external proxy -> rocklet -> TCP port
- Add comprehensive logging with target_port in all messages
- Handle both FastAPI WebSocket and websockets library APIs
- Add unit tests for port validation, URL building, and route handling
- Capture close frame (code, reason) when rocklet closes connection - Forward close frame to client instead of silently dropping - Properly wait for cancelled tasks to complete - Improve logging for connection close events
Address PR alibaba#523 review feedback - duplicate _validate_port function exists in both sandbox_proxy_service.py and local_api.py. - Add rock/common/port_validation.py with shared validate_port_forward_port() - Update sandbox_proxy_service.py to use shared function - Update local_api.py to use shared function - Add unit tests for the shared module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #601