Skip to content

Add package-lock.json to .gitignore#40

Open
Copilot wants to merge 5 commits intomainfrom
copilot/rename-render-canvas-to-render-root
Open

Add package-lock.json to .gitignore#40
Copilot wants to merge 5 commits intomainfrom
copilot/rename-render-canvas-to-render-root

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 9, 2026

This repo uses pnpm (pnpm-lock.yaml, pnpm-workspace.yaml, .npmrc). package-lock.json should not appear in the repository.

  • Add package-lock.json to .gitignore
Original prompt

This section details on the original issue you should resolve

<issue_title>Proposal: rename RenderCanvas to RenderRoot</issue_title>
<issue_description>One item that kept tripping me up was the name RenderCanvas. It's odd because it owns a <canvas> in this._el. What about RenderRoot?

  • Clear: it's the root of the render tree
  • Follows existing convention (Render prefix)
  • Similar to React's FiberRoot, Flutter's RenderView
  • No confusion with canvas elements</issue_description>

<agent_instructions>根据 Issue 的要求,实现需求,不要忘记更新单元测试</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 2 commits March 9, 2026 01:33
Rename the RenderCanvas class to RenderRoot throughout the codebase:
- Rename render-canvas.ts to render-root.ts
- Rename render-canvas.spec.ts to render-root.spec.ts
- Rename render-canvas.stories.tsx to render-root.stories.tsx
- Update all imports, exports, type references, and comments

Co-authored-by: zhanghaocong <180445+zhanghaocong@users.noreply.github.com>
Instead of removing RenderCanvas entirely, keep it as a @deprecated
alias for RenderRoot so existing consumers can migrate gradually.

Co-authored-by: zhanghaocong <180445+zhanghaocong@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename RenderCanvas to RenderRoot for clarity Rename RenderCanvas to RenderRoot with deprecated alias Mar 9, 2026
@zhanghaocong zhanghaocong marked this pull request as ready for review March 9, 2026 03:27
Copilot AI changed the title Rename RenderCanvas to RenderRoot with deprecated alias Rename RenderCanvas → RenderRoot with deprecated alias Mar 9, 2026
Co-authored-by: zhanghaocong <180445+zhanghaocong@users.noreply.github.com>
Copilot AI changed the title Rename RenderCanvas → RenderRoot with deprecated alias Enforce pnpm-only package management Mar 9, 2026
Co-authored-by: zhanghaocong <180445+zhanghaocong@users.noreply.github.com>
Copilot AI changed the title Enforce pnpm-only package management Add package-lock.json to .gitignore Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: rename RenderCanvas to RenderRoot

3 participants