fix: fix coverage report upload in workflow (wip)#30
Open
Conversation
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
Committed-by: nengli.ln from Dev container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Greptile Summary
This PR adds the
CODECOV_TOKENsecret to theUpload coverage to Codecovstep in.github/workflows/neug-test.yml, fixing authenticated uploads that were likely failing due to the missing token.token: ${{ secrets.CODECOV_TOKEN }}input was added to thecodecov/codecov-action@v4step.v4of the action), so omitting it causes uploads to be rejected or silently dropped.mainbranch push on the canonical repository).Confidence Score: 5/5
codecov/codecov-action@v4. The secret is referenced via the GitHub Secrets mechanism, so no credentials are exposed.Important Files Changed
CODECOV_TOKENsecret to the Codecov upload step — a straightforward fix that enables authenticated coverage uploads; no logic issues found.Sequence Diagram
sequenceDiagram participant GH as GitHub Actions Runner participant CC as Codecov Service GH->>GH: Run tests & generate coverage.info alt main branch push GH->>CC: Upload coverage report<br/>(with CODECOV_TOKEN secret) CC-->>GH: Upload acknowledged else other branches / non-push events GH->>GH: Skip upload (condition not met) endLast reviewed commit: f5b541d