Add environment variable exports for dependencies #6025
Conversation
Set environment variables for Herwig, GSL, ThePEG, and nlohmann_json packages. Tests with O2DPG generators were failing because these path are included when loading the environments, but not at building time.
|
|
||
| # Add Herwig, GSL, ThePEG and nlohmann_json packages to root include path and library path at building time | ||
| export ROOT_INCLUDE_PATH="$THEPEG_ROOT/include:$HERWIG_ROOT/include:$GSL_ROOT/include:$NLOHMANN_JSON_ROOT/include:$ROOT_INCLUDE_PATH" | ||
| export LD_LIBRARY_PATH="$THEPEG_ROOT/lib/ThePEG:$HERWIG_ROOT/lib/Herwig:$GSL_ROOT/lib:$LD_LIBRARY_PATH" |
There was a problem hiding this comment.
a better place for this is direclty in the "env" section of each recipe (which constructs the build environment for alibuild recipes). Then you don't have to do it in each recipe using Herwig...
There was a problem hiding this comment.
I had multiple issues while reproducing this on a local docker due to some path issues. We tested prepend-path with Giulio but it didn't work (aliBuild fails while building ThePEG or Herwig). I will check if env works, I would prefere it over exporting the path directly.
There was a problem hiding this comment.
Ok. I actually meant prepend_path. Not sure what the difference with env is... but anyways I think that such yaml setting would be more appropriate than manually doing exports.
There was a problem hiding this comment.
env sets the variable, prepend_path adds to it.
Historically, prepend_path and env are available only in dependencies, not in the actual build script, to make sure that the script was "standalone" and could be easily cut & pasted to reproduce issues. That said, the correct solution here would be to have the changes in HERWIG and ThePeg, however that cannot be done due to a relocation issue in pythia8, IIUC. Once we fix it, we can clean this up.
|
PR replaced by AliceO2Group/O2DPG#2174 |
3 participants
Set environment variables for Herwig, GSL, ThePEG, and nlohmann_json packages. Tests with O2DPG generators were failing because these path are included when loading the environments, but not at building time.