Skip to content

feat: to be compatible with some not standard error messages #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: to be compatible with some not standard error messages #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c2cf88
feat: pretty and to be compatible with some not standard error messag…
tq0fqeu Dec 21, 2020
700c3a4
fix: fix ut err
tq0fqeu Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/aliyunsdkcore/roa_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def request(method:, uri:, params: {}, body: {}, headers: {}, options: {})
response_content_type = response.headers['Content-Type'] || ''
if response_content_type.start_with?('application/json')
if response.status >= 400
result = JSON.parse(response.body)
raise StandardError, "code: #{response.status}, #{result['Message']} requestid: #{result['RequestId']}"
result = JSON.parse(response.body).transform_keys(&:downcase)
raise StandardError, "status: #{response.status}, code: #{result['code']}, message: #{result['message']}, requestid: #{result['requestid']}"
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/roa_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
.to_return(status: status, headers: headers, body: body)
expect {
roa_client.get(uri: '/', headers: { 'content-type': 'application/json' })
}.to raise_error(StandardError, 'code: 400, error message requestid: requestid')
}.to raise_error(StandardError, 'status: 400, code: errorcode, message: error message, requestid: requestid')
end
end

Expand Down