Skip to content

1161 spike investigate lab rendering approach#1256

Open
ejt7508 wants to merge 12 commits intodevfrom
1161-spike-investigate-lab-rendering-approach
Open

1161 spike investigate lab rendering approach#1256
ejt7508 wants to merge 12 commits intodevfrom
1161-spike-investigate-lab-rendering-approach

Conversation

@ejt7508
Copy link
Contributor

@ejt7508 ejt7508 commented Feb 12, 2026

  • Allowed page to grow with content
  • NavigationPane is sticky to move with the scroll and not be cut off
  • Changed padding and font weights of NavigationPane
  • Fixed back/next button sizing to not get cut off
  • Removed internal scroll bars
  • Made scroll bar always visible to avoid pushing content
  • Background stripes are fixed
  • Removed NavPane subtitles on small screens

Risks:

  • Removed overflow-x-hidden on some other files to allow a sticky element

  • Changed font weights and padding could make it more difficult to read

  • Changed main.js on every lab to remove internal scroll bar

  • Scroll always enabled could cause issues

  • No discrepancies across browsers (ex: chrome vs safari)

  • Accessibility functions

  • Pages can scale without distorting page

  • No dead links

  • Navbar is consistent across the site

  • Pages are screen-reader accessible

  • Contrast meets standards for accessibility

  • Pages are keyboard accessible

  • Code is cleaned up and bug-free (ex: debug statements removed)

@ejt7508 ejt7508 linked an issue Feb 12, 2026 that may be closed by this pull request
@ejt7508 ejt7508 requested review from JackyFTW and wlh3903 February 12, 2026 15:27
@ejt7508 ejt7508 marked this pull request as ready for review February 17, 2026 16:36
@shmowen
Copy link
Contributor

shmowen commented Feb 17, 2026

It's worth reaching out to Chrissy and asking her opinion on some of these styling things. Things like how high the background boxes should be, should the Table of Contents be stretched to the bottom of the page, etc.

Screenshot 2026-02-17 at 12 21 37 PM

Copy link
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through a few combinations of newer and older labs and this looks fantastic. Very nice job!


return (
<div className={"tw-overflow-y-scroll"}>
<div className={""}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove className={""}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spike: Investigate Lab Rendering Approach

2 participants