Skip to content

1162 epic improve lab searching#1260

Open
ejt7508 wants to merge 22 commits intodevfrom
1162-epic-improve-lab-searching
Open

1162 epic improve lab searching#1260
ejt7508 wants to merge 22 commits intodevfrom
1162-epic-improve-lab-searching

Conversation

@ejt7508
Copy link
Contributor

@ejt7508 ejt7508 commented Feb 12, 2026

  • Used tw-w-full to prevent some searches from displaying labs with a smaller width
  • Removed search button
  • Search is automatic even with filters
  • Added filtering module
  • Allowed for combined searches (difficulty+topic+text)

Risks

  • Refactored searching and removed some unneeded variables

  • No discrepancies across browsers (ex: chrome vs safari)

  • Accessibility functions

  • Pages can scale without distorting page

  • No dead links

  • Navbar is consistent across the site

  • Pages are screen-reader accessible

  • Contrast meets standards for accessibility

  • Pages are keyboard accessible

  • Code is cleaned up and bug-free (ex: debug statements removed)

@ejt7508 ejt7508 linked an issue Feb 12, 2026 that may be closed by this pull request
@ejt7508
Copy link
Contributor Author

ejt7508 commented Feb 12, 2026

If we want search to be automatic, should I remove the search button?

@ejt7508 ejt7508 requested review from JackyFTW and wlh3903 February 12, 2026 17:14
@shmowen
Copy link
Contributor

shmowen commented Feb 12, 2026

  • Changed search icon to a magnifying glass

Honestly yeah, I don't see a need for both to be there.

@JackyFTW
Copy link
Contributor

  • Changed search icon to a magnifying glass

Honestly yeah, I don't see a need for both to be there.

Agreed. Also look at #ui-ux channel on Discord for additional styling changes for the filtering stuff and mobile tweaks.

…adio buttons; Refactored search logic to allow combined searches
@ejt7508 ejt7508 marked this pull request as ready for review February 19, 2026 18:36
Copy link
Contributor

@shmowen shmowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there are no labs that match the filters given, I think there should be a small message that says something along the lines of:

"There are no labs that fit these filters! Try some different search options to find the lab you're looking for"

Doesn't have to be that exactly btw.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Epic: Improve Lab Searching

3 participants