Open
Conversation
Contributor
ConnerDeFeo
commented
Feb 19, 2026
ConnerDeFeo
commented
- No discrepancies across browsers (ex: chrome vs safari)
- Accessibility functions
- Pages can scale without distorting page
- No dead links
- Navbar is consistent across the site
- Pages are screen-reader accessible
- Contrast meets standards for accessibility
- Pages are keyboard accessible
- Code is cleaned up and bug-free (ex: debug statements removed)
- Implement hasPiechartInBody() helper for intentional pie chart rendering - Add piechart type option in body loop - Add 6 sections of reading content
- Remove tw-overflow-y-auto from App.js to take away duplicate scrolling - Add tw-h-[35rem] to Reading.js container for height constraint - Add tw-overflow-y-scroll to inner content div for scroll behavior - Update About section with lab description - Merge 'How AI Design Amplifies Bias' into 'What Can We Do About It' section - Improve AI literacy explanation
…ise-ranking ThisMerge branch 'development/lab13' of github.com:all-rit/ALL into exercise-ranking Pulling in Lab 0
…ionatlity to move on to next component
Routing implementation
…ng on the AI Panel Page
Quiz Section for Lab13
- Added typewriter effect for bot responses - Added fade in animations for new messages - Added auto scroll down functionality while typing - Disable dropdown toggle while AI is typing to prevent multiple response generation - Styled bot and user messages
…-fix AI Typing Animation Update
… point im lazy and dont wanna make a context for the lab
shmowen
requested changes
Mar 5, 2026
Contributor
shmowen
left a comment
shmowen
left a comment
There was a problem hiding this comment.
Have a few changes that need fixing. Ended up getting stuck on the AIPanel after the repair as well.
PLEASE run npm run lint in the /client folder as well.
client/src/components/exercise/lab13/pages/ExerciseIntroduction.js
Outdated
Show resolved
Hide resolved
client/src/components/exercise/lab13/components/AIPanel/AIChatBotTab.js
Outdated
Show resolved
Hide resolved
client/src/components/exercise/lab13/components/AIPanel/AIChatBotTab.js
Outdated
Show resolved
Hide resolved
shmowen
requested changes
Mar 6, 2026
Contributor
shmowen
left a comment
shmowen
left a comment
There was a problem hiding this comment.
There are 9 console warnings that pop up when running through the exercise. These should be fixed por favor.
client/src/components/exercise/lab13/components/AIPanel/AIChatBotTab.js
Outdated
Show resolved
Hide resolved
shmowen
requested changes
Mar 16, 2026
Contributor
shmowen
left a comment
shmowen
left a comment
There was a problem hiding this comment.
fix these and then ill approve
Contributor
Author
|
ALL (get it) changes made |
JackyFTW
requested changes
Mar 16, 2026
Contributor
JackyFTW
left a comment
JackyFTW
left a comment
There was a problem hiding this comment.
Some changes requested. Most revolving around backend stuff to look into please.
| { | ||
| id: "dyslexia", | ||
| title: "Dyslexia", | ||
| body: "", |
Contributor
There was a problem hiding this comment.
Instead of "body" here, maybe it should be "content"? Getting a warning when the first card is put in a category:
Contributor
Author
There was a problem hiding this comment.
This was fixed did you git pull? I cannot recreate this on my end
client/src/components/exercise/lab13/pages/repairs/IDEExerciseImplementation.js
Outdated
Show resolved
Hide resolved
JackyFTW
approved these changes
Mar 17, 2026
Contributor
JackyFTW
left a comment
JackyFTW
left a comment
There was a problem hiding this comment.
LGTM outside of small warnings I already mentioned, good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.