Fix indentation in resume-training checkpoint logic#33
Open
hq-fang wants to merge 1 commit intoallenai:mainfrom
Open
Fix indentation in resume-training checkpoint logic#33hq-fang wants to merge 1 commit intoallenai:mainfrom
hq-fang wants to merge 1 commit intoallenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resuming training, the checkpoint-loading snippet was incorrectly nested under
As a result, only GPU rank 0 ever attempted to load the model state. All other ranks idled at the barrier and eventually timed out.
This PR gives a simple fix on the indentation so that every rank invokes the checkpoint loader. So the fixed snippet looks like
With this change, all processes load the checkpoint in parallel, and training resumes smoothly on multi-GPU setups.