Conversation
Replace sqlmock-based unit tests with integration tests using real PostgreSQL and MySQL databases via Docker Compose. This provides more accurate testing by validating actual SQL queries and database behavior against production-like environments. Changes: - Add docker-compose.test.yml for test database infrastructure (PostgreSQL on 5433, MySQL on 3307) - Create testutil/database.go with helpers for database setup, migrations, and cleanup - Update all repository tests to use real databases instead of sqlmock - Remove go-sqlmock dependency from go.mod - Add Makefile targets: test-db-up, test-db-down, test-with-db - Update CI workflow to run both PostgreSQL and MySQL services for comprehensive testing - Update README with detailed testing documentation and best practices Benefits: - Tests verify actual SQL queries work correctly with real databases - Catches database-specific issues (constraints, types, unique violations) - No mock expectations to maintain - Tests reflect production behavior accurately - Full database integration coverage with ~15 second test suite execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace sqlmock-based unit tests with integration tests using real PostgreSQL and MySQL databases via Docker Compose. This provides more accurate testing by validating actual SQL queries and database behavior against production-like environments.
Changes:
Benefits: