EAbranch#2
Open
EAliakberov wants to merge 4 commits intoalnikmakh:mainfrom
Open
Conversation
alnikmakh
reviewed
Sep 16, 2022
| margin: 0%; | ||
|
|
||
|
|
||
| font-family: sans-serif; |
Owner
There was a problem hiding this comment.
font-family обычно указывается у body и наследуется всеми дочерними элементами, а так тебе у каждого элемента нужно будет прописывать
|
|
||
| } | ||
|
|
||
| .Logo{ |
| <img src="" alt="Картинка длинной селфи-палки"> | ||
| </div> | ||
|
|
||
| <div class="adv-section-description"> |
Owner
There was a problem hiding this comment.
если это БЭМ, то тут что-то не так с правилами нейминга) элемент через двойное нижнее подчеркивание, модификатор через двойное тире. При этом нельзя просто класс-модификатор применить к тегу. Модификатор на то и модификатор, чтобы работать в дополнении основного класса
| <section class="last-section"> | ||
| <h1 class="hidden-header">Последняя секция</h1> | ||
| <section class="section-about-us"> | ||
| <h1 class="header1">О нас</h1> |
Owner
There was a problem hiding this comment.
учись сразу называть нормально)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Сделал разметку 1й страницы и чуток css