Fixes exception due to ast parser changes.#30
Open
comfuture wants to merge 13 commits intoalonho:masterfrom
Open
Fixes exception due to ast parser changes.#30comfuture wants to merge 13 commits intoalonho:masterfrom
comfuture wants to merge 13 commits intoalonho:masterfrom
Conversation
> since version 3.8: Methods visit_Num(), visit_Str(), visit_Bytes(), visit_NameConstant() and visit_Ellipsis() are deprecated now and will not be called in future Python versions. Add the visit_Constant() method to handle all constant nodes. related alonho#29
Add handle_UnaryOp to IntField
Add a function that recognizes the version and converts it to a number
|
Would love to see this get merged in and released upstream to allow upgrades to python 3.8 |
|
@alonho is there anyway you could merge this and release a new version on pypy to allow for python 3.8 compatability? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wrote quick fix of #29 by producing
handle_Constant()method for each AstHandlers.And the existing
handle_Num(),handle_Str(), .. methods were left untouched to obtain backward compatibility.See https://docs.python.org/3/library/ast.html#ast.NodeVisitor.generic_visit