Open
Conversation
sbastrakov
reviewed
Sep 19, 2019
|
|
||
| #if !defined(ALPAKA_ACC_GPU_CUDA_ENABLED) && !defined(ALPAKA_ACC_GPU_HIP_ENABLED) | ||
| #if defined(__GNUC__) || defined(__GNUG__) | ||
| #define __popc __builtin_popcount |
Member
There was a problem hiding this comment.
Maybe this is better as a function-style macro (taking an argument explicitly) for consistency with others?
Member
There was a problem hiding this comment.
Yes we should use a function style macro!+1 for function style macro
psychocoderHPC
requested changes
Sep 26, 2019
|
|
||
| #if !defined(ALPAKA_ACC_GPU_CUDA_ENABLED) && !defined(ALPAKA_ACC_GPU_HIP_ENABLED) | ||
| #if defined(__GNUC__) || defined(__GNUG__) | ||
| #define __popc __builtin_popcount |
Member
There was a problem hiding this comment.
Yes we should use a function style macro!+1 for function style macro
Member
|
Note: alpaka now has popcount. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change or extend as you like.
Edit there is also
__max, which has to be seen as hotfix.The problem was, that max and min cannot be used as macro, it conflicted user methods with same name. Maybe we use just a global function instead when max and min are not defined respectively, this should be better than this hotfix now.