Improve StreamFlowExecutor termination protocol#1000
Open
GlassOfWhiskey wants to merge 1 commit intomasterfrom
Open
Improve StreamFlowExecutor termination protocol#1000GlassOfWhiskey wants to merge 1 commit intomasterfrom
StreamFlowExecutor termination protocol#1000GlassOfWhiskey wants to merge 1 commit intomasterfrom
Conversation
GlassOfWhiskey
force-pushed
the
better-executor-termination
branch
from
cd51baf to
8432b55
Compare
LanderOtto
approved these changes
Mar 21, 2026
This commit improves the termination protocol of the `StreamFlowExecutor` class, adopting the same behaviour used in `BaseShell`. This new protocol should guarantee that all tasks are correctly terminated before closing the `StreamFlowContext`, allowing cleaner terminations of the StreamFlow application.
GlassOfWhiskey
force-pushed
the
better-executor-termination
branch
from
8432b55 to
52f1641
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
==========================================
- Coverage 73.82% 73.74% -0.08%
==========================================
Files 91 91
Lines 12481 12497 +16
Branches 2186 2190 +4
==========================================
+ Hits 9214 9216 +2
- Misses 2743 2752 +9
- Partials 524 529 +5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the termination protocol of the
StreamFlowExecutorclass, adopting the same behaviour used inBaseShell. This new protocol should guarantee that all tasks are correctly terminated before closing theStreamFlowContext, allowing cleaner terminations of the StreamFlow application.