Correctly skip nested subworkflows#1019
Merged
GlassOfWhiskey merged 1 commit intomasterfrom Apr 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
+ Coverage 74.35% 74.39% +0.03%
==========================================
Files 90 90
Lines 12492 12495 +3
Branches 2192 2192
==========================================
+ Hits 9289 9296 +7
+ Misses 2682 2680 -2
+ Partials 521 519 -2 ☔ View full report in Codecov by Sentry. |
This commit ensures that, when a nested workflow must be skipped, `None` tokens are only propagated to the output ports of the workflow itself, and not to the inputs of the inner steps. A CWL test has been added to avoid regressions.
GlassOfWhiskey
force-pushed
the
conditional-nested-workflows
branch
from
a47c6ca to
17442e5
Compare
LanderOtto
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures that, when a nested workflow must be skipped,
Nonetokens are only propagated to the output ports of the workflow itself, and not to the inputs of the inner steps. A CWL test has been added to avoid regressions.