Skip to content

Conversation

@andyhd
Copy link
Contributor

@andyhd andyhd commented Dec 13, 2023

  • Already using pydantic via FastAPI
  • Less to maintain
  • Typed settings - catches config errors

@andyhd andyhd added the norelease Don't bump version number or create a release label Dec 13, 2023
@andyhd andyhd requested review from guifry and nacnudus December 13, 2023 14:03
@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch 2 times, most recently from 2089f39 to 93f6cc2 Compare December 13, 2023 14:27
guifry
guifry previously approved these changes Dec 13, 2023
Copy link
Contributor

@guifry guifry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch from 93f6cc2 to 3d8dd31 Compare December 13, 2023 16:36
* Already using pydantic via FastAPI
* Less to maintain
* Typed settings - catches config errors
@andyhd andyhd force-pushed the andyhd/chore/refactor-config-to-pydantic-settings branch from 3d8dd31 to b675eab Compare December 13, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

norelease Don't bump version number or create a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants