fix: e2e tests #233
Open
fix: e2e tests #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
2 times, most recently
from
7e681de to
aa12bab
Compare
guifry
changed the base branch from
main
to
guilhemf/fix/handle-bad-response-format
nacnudus
previously approved these changes
Feb 28, 2024
guifry
force-pushed
the
guilhemf/fix/handle-bad-response-format
branch
4 times, most recently
from
68faff6 to
632d430
Compare
* It's tricky so i made this WIP commit * Using YAML anchors and aliases
* Also disable annoying formatting for e2e tests
filtering by domain
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
from
f69aa94 to
9268a91
Compare
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
3 times, most recently
from
3380d08 to
d725a57
Compare
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
from
d725a57 to
ce6e02a
Compare
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
from
176b62e to
2949f13
Compare
guifry
force-pushed
the
guilhemf/fix/e2e-tests
branch
from
2949f13 to
5e931f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E tests setup kept breaking due to there multiple points of failure:
I've ditched Selenium in favour of the Playrwight framework.
Previously, the E2E tests containers had to run its own single consent API.
Now, the container for E2E tests only cares about running playwright, enhancing the separation of concern.
Makefile
Because we don't need to manage so many Selenium and migrations parameters anymore, I've simplified the Makefile to the essential commands.
docker-compose
I've also re-organised the docker compose configuration by leveraging YAML inheritance syntax