WIP: Rewrite UpdateStatus as an ES Module #5366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
force-pushed
the
rewrite-update-status-as-esm
branch
3 times, most recently
from
8d82c99 to
f020541
Compare
kr8n3r
changed the title
kr8n3r
force-pushed
the
rewrite-update-status-as-esm
branch
from
f020541 to
88b80bc
Compare
kr8n3r
force-pushed
the
rewrite-update-status-as-esm
branch
from
88b80bc to
b6c98ec
Compare
We want to migrate all of our legacy Javascript files to ESM, so this is the latest in the series of conversions. Rewrite follows the same conventions we previously used for FocusBanner, Collapsible checkboxes, ColourPreview, FileUpload, Autofocus, PreviewPane, CopyToClipboard and others. We Fetch API to do teh posting instead of jQuery's AJAX. In this PR we: - rewrite the module as ES Module - update the tests to be ES Module - remove old module JS file - remove old module from the legacy bundle build
kr8n3r
force-pushed
the
rewrite-update-status-as-esm
branch
from
b6c98ec to
90915c8
Compare
kr8n3r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to migrate all of our legacy Javascript files to ESM, so this is the latest in the series of conversions.
Rewrite follows the same conventions we previously used for FocusBanner, Collapsible checkboxes, ColourPreview, FileUpload, Autofocus, PreviewPane, CopyToClipboard, EnhancedTextbox and others.
Added bonus: removes the use of jQuery and use Fetch API
In this PR we:
How to test
Edit SMS template page is the easiest as the "Will be charged as 1 text message" is updated using this script