Remove uses of datetime.utcnow
#5489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`datetime.utcnow` is deprecated as of Python 3.12: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow The docs say: > Use `datetime.now()` with `datetime.UTC` instead. There are a few cases where we pass serialised datetimes to the API. Because the API might be expecting datetimes in a particular format I’ve written a couple of helper methods to deal with this. In the future we could investiagate whether the API really needs datetimes in those specific formats.
`datetime.utcnow` is deprecated as of Python 3.12: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow The docs say: > Use `datetime.now()` with `datetime.UTC` instead. Doing this as a separate commit so it’s easy to see that the app changes pass the existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.utcnowis deprecated as of Python 3.12: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnowThe docs say:
There are a few cases where we pass serialised datetimes to the API. Because the API might be expecting datetimes in a particular format I’ve written a couple of helper methods to deal with this. In the future we could investigate whether the API really needs datetimes in those exact formats.
I’ve changed the tests as a separate commit so it’s easy to see that:
You can verify this by running
git rebase origin/main -ix "make test"