Dockerfile: Inline contents of unit-tests-image
#5499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to migrate all of our images from GHCR to ECR, and as part of that we want to remove/retire any images that we no longer need (rather than migrating them to ECR and continuing to build/use them). unit-tests-image is currently used as a base image for both admin & document-download-frontend. This is not ideal because (presumably) both apps have different dependency requirements, but by sharing the same base image they both have the union of each of their requirements, which is a waste of storage. This commit inlines the contents of unit-tests-image's Dockerfile into admin's.
robinjam
changed the title
unit-tests-image
kr8n3r
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
We want to migrate all of our images from GHCR to ECR, and as part of that we want to remove/retire any images that we no longer need (rather than migrating them to ECR and continuing to build/use them).
unit-tests-imageis currently used as a base image for "frontend builds" of bothadmin&document-download-frontend. This is not ideal because (presumably) both apps have different dependency requirements, but by sharing the same base image they both have the union of each of their requirements, which is a waste of storage. (It's also just confusing)This PR inlines the contents of
unit-tests-image'sDockerfileintoadmin's.