PP-15194 Use endtoend tag in zap docker-compose#1508
Merged
Conversation
- There is no endtoendzap tag being set by end-to-end test pipelines and also CodeBuild project doesn't define equivalent env variable
benjamb
approved these changes
Apr 24, 2026
benjamb
reviewed
Apr 24, 2026
|
|
||
| endtoend: | ||
| image: ${DOCKER_REGISTRY_URI:-}${repo_endtoendzap:-govukpay/endtoend-zap}:${tag_endtoendzap:-latest} | ||
| image: ${DOCKER_REGISTRY_URI:-}${repo_endtoendzap:-govukpay/endtoend-zap}:${tag_endtoend:-latest} |
Contributor
There was a problem hiding this comment.
Cool! I'd just spotted this, but wasn't sure if we wanted to ensure tag_endtoendzap was actually set, given they are in separate projects/repos, or whether to just do this.
Contributor
Author
There was a problem hiding this comment.
There will be several places that need to be updated and need to be done in order. We can look into it separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
tag_endtoendzaptag being set by end-to-end test pipelines, and also the CodeBuild project doesn't define an equivalent env variable https://github.com/alphagov/pay-infra/blob/9215ab5ae62364ae443d2400d2ede6ff2d1b6b03/provisioning/terraform/modules/pay_codebuild/endtoend_tests/buildspec.yml#L5