Conversation
emmalowe
commented
Apr 24, 2026
The govuk index will be the only relevant index to run these rake tasks on, once the government index has been retired (this is in progress). The duplicates are located by content_id, which only appears as a field in the content indexes and not the auxiliary indexes.
40569d1 to
fe167bc
Compare
This code can be simplified now that we're only using the duplicates rake tasks on the govuk index.
This has been broken since 2020, so it seems unlikely that it will be missed. We can get the results in a json format from search API anyway. See PR that broke the task: #2062
The govuk index will be the only relevant index to run this rake task on, once the government index has been retired (this is in progress). That's because the format field only appears in the content indexes, not the auxiliary indexes.
The govuk index will be the only relevant index to run this rake task on, once the government index has been retired (this is in progress). That's because the title and description fields only appear in the content indexes, not the auxiliary indexes.
The govuk index will be the only relevant index to run this rake task on, once the government index has been retired (this is in progress). That's because the content_store_document_type fields only appears in the content indexes, not the auxiliary indexes.
All documents have now been migrated to the govuk index, so we can remove references to other indices.
fe167bc to
545abd6
Compare
Contributor
Author
|
@koetsier I've refactored the duplicates code - do you mind reviewing this again please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to government index in search-api rake tasks where relevant, in preparation of retiring the government index.
Jira ticket: https://gov-uk.atlassian.net/browse/SCH-2034