Conversation
This is not documented and not used so it is better to remove
|
I think it would be helpful to add some context to the commit message. Here's what I found:
|
emmalowe
left a comment
There was a problem hiding this comment.
Code changes look good to me. Just the comment about putting the context on the commit message, and then a small nitpick if you feel like addressing that.
There was a problem hiding this comment.
nit-pick: this file should be called sort_spec.rb really
This is not documented and not used so it is better to remove.
Jira: https://gov-uk.atlassian.net/browse/SCH-2062