Skip to content

Remove similar_to functionality#3607

Open
koetsier wants to merge 1 commit intomainfrom
remove_similar_to
Open

Remove similar_to functionality#3607
koetsier wants to merge 1 commit intomainfrom
remove_similar_to

Conversation

@koetsier
Copy link
Copy Markdown
Contributor

@koetsier koetsier commented Apr 29, 2026

This is not documented and not used so it is better to remove.

Jira: https://gov-uk.atlassian.net/browse/SCH-2062

This is not documented and not used so it is better to remove
@emmalowe
Copy link
Copy Markdown
Contributor

emmalowe commented May 1, 2026

I think it would be helpful to add some context to the commit message. Here's what I found:

Copy link
Copy Markdown
Contributor

@emmalowe emmalowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Just the comment about putting the context on the commit message, and then a small nitpick if you feel like addressing that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick: this file should be called sort_spec.rb really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants