-
Notifications
You must be signed in to change notification settings - Fork 17
Fix all broken links and add link checker #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8d7ce74
Set up html-proofer as the link checker
e50c6bc
Put tech-docs-gem/docs content in the docs repo
e500890
Remove gem_docs helper
00e2497
Bring in images from the tech docs gem repo
32528eb
Fix links to images which are now in the `images` folder
3fb24e9
Move diagrams to the `images` folder
6d72597
Dix diagram linking after moving to the `images` folder
b0184cf
Fix links that broke as a result of the restructuring in PR#97
5fc0204
Merge branch 'master' into fix-all-broken-links-forever
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| require 'govuk_tech_docs' | ||
|
|
||
| GovukTechDocs.configure(self, livereload: { js_host: "localhost" }) | ||
|
|
||
| DOCS_LOCATION_IN_GEM = Bundler.rubygems.find_name('govuk_tech_docs').first.full_gem_path + "/docs" | ||
|
|
||
| files.watch :source, path: DOCS_LOCATION_IN_GEM | ||
| # Check for broken links | ||
| require 'html-proofer' | ||
|
|
||
| helpers do | ||
| def gem_docs(filename) | ||
| raw_markdown = File.read(DOCS_LOCATION_IN_GEM + "/#{filename}") | ||
|
|
||
| # Strip the h1 header from the original markdown file | ||
| markdown = raw_markdown.lines[1..-1].join | ||
| GovukTechDocs.configure(self, livereload: { js_host: "localhost" }) | ||
|
|
||
| markdown | ||
| after_build do |builder| | ||
| begin | ||
| HTMLProofer.check_directory(config[:build_dir], | ||
| { :assume_extension => true, | ||
| :disable_external => true, | ||
| :allow_hash_href => true, | ||
| :url_swap => { config[:tech_docs][:host] => "" } }).run | ||
| rescue RuntimeError => e | ||
| abort e.to_s | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we need to do a pull request on the gem repo to remove content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup - I've raised this PR to cover the content move: alphagov/tech-docs-gem#151