-
Notifications
You must be signed in to change notification settings - Fork 37
Google Tag Manager layout addition #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @lfdebrux, We're really keen to use GTM on our docs-as-code sites. This PR seems to do just that (thanks @grahampaulcook 🙏 ). I think the only conflict with the latest, greatest code is a single line in version.rb. If we could get this resolved would you consider this for inclusion? Many thanks, Edd |
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime. (cherry picked from commit 671dd75)
|
Good stuff but let's do this in v4.1 |
|
hey @grahampaulcook / @eddgrant Really sorry I know this is a ridiculously old request now and you've all probably moved on. Can i check where your needs are these days, are you still using GTM or does GA4 now cover those needs? |
|
Hey @huwd , No worries at all, thanks for getting back to us! I'm still using GA4 for analytics, but I'm deploying it using GTM (which is a soure of eternal confusion to me if I'm honest). I'm doing this as it seems to me to that GTM is Google's recommended way to deploy GA4, or at least that's how I've understood it. Hope that helps! |
|
Ok great, I'll see if I can find some time and sneak this into a release whilst me and the community have eyeballs on this. |
Introduce Google Tag Manager support into technical documentation services by adding a new configuration option in the
config/tech-docs.ymlfile.gtm_id: GTM-xxxxxThe documentation changes are within alphagov/tdt-documentation#126