Skip to content

refactor: remove redundant free-course check in create_payment_intent #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankushchk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove redundant free-course check in create_payment_intent #1005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions web/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1603,7 +1603,7 @@ def create_payment_intent(request, slug):
course = get_object_or_404(Course, slug=slug)

# Prevent creating payment intents for free courses
if course.price == 0:
if course.price <= 0:
# Find the enrollment and update its status to approved if it's pending
enrollment = get_object_or_404(Enrollment, student=request.user, course=course)
if enrollment.status == "pending":
Expand All @@ -1619,17 +1619,6 @@ def create_payment_intent(request, slug):
# Ensure user has a pending enrollment
enrollment = get_object_or_404(Enrollment, student=request.user, course=course, status="pending")

# Validate price is greater than zero for Stripe
if course.price <= 0:
enrollment.status = "approved"
enrollment.save()

# Send notifications
send_enrollment_confirmation(enrollment)
notify_teacher_new_enrollment(enrollment)

return JsonResponse({"free_course": True, "message": "Enrollment approved for free course"})

try:
# Create a PaymentIntent with the order amount and currency
intent = stripe.PaymentIntent.create(
Expand Down