Add ros_environment package to docker image#191
Merged
Conversation
f-fl0
approved these changes
Mar 17, 2026
Contributor
f-fl0
left a comment
f-fl0
left a comment
There was a problem hiding this comment.
LGTM. I just left a minor comment.
| python3 \ | ||
| sed | ||
| sed \ | ||
| ros-${ROS_DISTRO}-ros-environment |
Contributor
There was a problem hiding this comment.
We might want to keep the list of packages to install in alphabetical order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to add ROS_VERSION environment variable like alpine-ros/alpine-ros#50, but, in this repository, a single Dockerfile is shared by ROS_DISTROs and the docker image is only for building packages. So this way might be simpler.