Skip to content

Fix library dependency of sdl on 3.23#248

Merged
at-wat merged 2 commits intoalpine-custom-apkfrom
fix-sdl12-compat-library-dep
Apr 17, 2026
Merged

Fix library dependency of sdl on 3.23#248
at-wat merged 2 commits intoalpine-custom-apkfrom
fix-sdl12-compat-library-dep

Conversation

@at-wat
Copy link
Copy Markdown
Member

@at-wat at-wat commented Apr 16, 2026

sdl12-compat-dev is used for sdl rosdep key since 3.23 but the actual library sdl2 should be also installed to add a runtime dependency.

@at-wat at-wat self-assigned this Apr 16, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@at-wat at-wat requested a review from f-fl0 April 16, 2026 07:09
Copy link
Copy Markdown

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit dbb4140 into alpine-custom-apk Apr 17, 2026
4 checks passed
@at-wat at-wat deleted the fix-sdl12-compat-library-dep branch April 17, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants