Skip to content

Develop#82

Merged
altaskur merged 2 commits intomainfrom
develop
Feb 17, 2026
Merged

Develop#82
altaskur merged 2 commits intomainfrom
develop

Conversation

@altaskur
Copy link
Copy Markdown
Owner

This pull request updates the update checking logic and tests for the UpdateService to handle multiple releases from the GitHub API, filter out draft releases, and improve test coverage for these scenarios. The main focus is ensuring that only non-draft releases are considered for updates, and the code and tests now expect the GitHub API to return an array of releases.

Update logic improvements:

  • Changed the GitHub releases API URL in UpdateService to fetch all releases instead of just the latest, and updated the logic to filter out draft releases while still allowing prereleases. [1] [2]
  • Modified the update check result to use the first non-draft release's information for version, URL, and release notes.

Test updates:

  • Updated all relevant tests in update.service.spec.ts to expect an array of releases from the mock API, and added the draft and prerelease fields to mock release objects. [1] [2] [3] [4]
  • Added a new test case to verify that draft releases are ignored when checking for updates.

Type/interface changes:

  • Added draft and prerelease properties to the GitHubRelease interface to match the fields returned by the GitHub API.

@sonarqubecloud
Copy link
Copy Markdown

@altaskur altaskur merged commit 2d1d32f into main Feb 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant