Conversation
fix(update): check all releases to support prereleases & drafts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates the update checking logic and tests for the
UpdateServiceto handle multiple releases from the GitHub API, filter out draft releases, and improve test coverage for these scenarios. The main focus is ensuring that only non-draft releases are considered for updates, and the code and tests now expect the GitHub API to return an array of releases.Update logic improvements:
UpdateServiceto fetch all releases instead of just the latest, and updated the logic to filter out draft releases while still allowing prereleases. [1] [2]Test updates:
update.service.spec.tsto expect an array of releases from the mock API, and added thedraftandprereleasefields to mock release objects. [1] [2] [3] [4]Type/interface changes:
draftandprereleaseproperties to theGitHubReleaseinterface to match the fields returned by the GitHub API.