Introduction of .editorfconfig and php-cs-fixer.#11
Closed
EvilKarter wants to merge 2 commits intoaltcha-org:mainfrom
EvilKarter:feature/sqs
Closed
Introduction of .editorfconfig and php-cs-fixer.#11EvilKarter wants to merge 2 commits intoaltcha-org:mainfrom EvilKarter:feature/sqs
EvilKarter wants to merge 2 commits intoaltcha-org:mainfrom
EvilKarter:feature/sqs
Conversation
Contributor
|
Thanks for the PR, I had to rebase it so merged from another branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #10 and should be merged afterwards
This PR is also switching to PHP 8.1 like #9.
This PR introduces editrofconfig and php-cs-fixer. It serves as a basis for enforcing standardized formatting.
the Github workflow has been extended by the php-cs-fixer check and phpstan.
The current .editorfconfig was taken from the Symfony Project.
The PHP-CS-Fixer config was based on the one from Symfony. However, some rules were adjusted manually to reflect the current code conditions.
What needs to be discussed:
@aleho fyi