Skip to content

Conversation

@luca-schlecker
Copy link
Contributor

The ALVR-Nightly build pipeline for windows currently fails due to what seems like these two issues:

  1. The launcher cannot be built because the required libvpl license is missing. The launcher does not prepare the dependencies like the streamer, thus not downloading libvpl and its license.
  2. The streamer cannot be built because cargo-about denies outputting to stdout in PowerShell.
[ERROR] cargo-about should not redirect its output in powershell, please use the -o, --output-file option to redirect to a file to avoid powershell encoding issues

This PR should address both by

  • making copying the libvpl license optional (like for example the ffmpeg license) and
  • using the suggested -o parameter.

I assume that the launcher does not need the libvpl license as it is included with the streamer (where the library is actually used).

packaging the launcher does not prepare the dependencies like packaging
the streamer, leaving libvpl and its license missing.
…ut file

cargo-about does not like powershell as it messes up encoding and thus
requires the "-o" parameter for specifying an output file.
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. But why was the vpl license file not found in the first place?

@luca-schlecker
Copy link
Contributor Author

Seems good to me. But why was the vpl license file not found in the first place?

From what I have seen, only the launcher build was missing the vpl license. Packaging the launcher does not prepare the dependencies, a required step for vpl to be downloaded.

The streamer, however, did download it and only failed because of the Powershell issue with cargo-about.

@zmerp
Copy link
Member

zmerp commented Jan 8, 2026

Anyway I think this is alright, thanks

@zmerp zmerp added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2026
@zmerp
Copy link
Member

zmerp commented Jan 8, 2026

Uh, can't merge because check-licenses failed. But I don't think it's because of this PR. I may not be able to fix this for a while though

@The-personified-devil
Copy link
Collaborator

Can you change what commit an existing release points to? Because it's literally installed version and dependency locked, I can't imagine how anything could change...

@The-personified-devil
Copy link
Collaborator

Did one of our deps change license? Since I'm assuming it's not building locked...

@The-personified-devil
Copy link
Collaborator

I figured it out, for some godforsaken reason if when outputting to stdout it encounters an error it just emits the error to stderr and outputs the data for every license it successfully parsed and doesn't set any exit status, so it wasn't tripping up the CI beforehand.

@The-personified-devil
Copy link
Collaborator

@zmerp It's caused by a singular test in the nix crate, we can either add that as a cargo-about ignore or we downgrade cargo-about to 0.7.1, which however seems to greedily check clearlydefined.io even if local information should be enough, so in that case I'd like to disable checking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants