-
-
Notifications
You must be signed in to change notification settings - Fork 608
fix nightly build issues #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix nightly build issues #3173
Conversation
packaging the launcher does not prepare the dependencies like packaging the streamer, leaving libvpl and its license missing.
…ut file cargo-about does not like powershell as it messes up encoding and thus requires the "-o" parameter for specifying an output file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. But why was the vpl license file not found in the first place?
From what I have seen, only the launcher build was missing the vpl license. Packaging the launcher does not prepare the dependencies, a required step for vpl to be downloaded. The streamer, however, did download it and only failed because of the Powershell issue with |
|
Anyway I think this is alright, thanks |
|
Uh, can't merge because check-licenses failed. But I don't think it's because of this PR. I may not be able to fix this for a while though |
|
Can you change what commit an existing release points to? Because it's literally installed version and dependency locked, I can't imagine how anything could change... |
|
Did one of our deps change license? Since I'm assuming it's not building locked... |
|
I figured it out, for some godforsaken reason if when outputting to stdout it encounters an error it just emits the error to stderr and outputs the data for every license it successfully parsed and doesn't set any exit status, so it wasn't tripping up the CI beforehand. |
|
@zmerp It's caused by a singular test in the |
The ALVR-Nightly build pipeline for windows currently fails due to what seems like these two issues:
cargo-aboutdenies outputting to stdout in PowerShell.This PR should address both by
-oparameter.I assume that the launcher does not need the libvpl license as it is included with the streamer (where the library is actually used).