feat: bank reconciliation rule

banking/custom/bank_account.js

@@ -0,0 +1,35 @@
+// Copyright (c) 2025, ALYF GmbH and contributors
+// For license information, please see license.txt
+
+frappe.ui.form.on("Bank Account", {
+	refresh(frm) {
+		frm.trigger("set_fee_account_query");
+	},
+
+	account(frm) {
+		frm.trigger("set_fee_account_query");
+	},
+
+	async set_fee_account_query(frm) {
+		if (!frm.doc.account) {
+			return;
+		}
+
+		const {
+			message: { account_currency: currency, company: company },
+		} = await frappe.db.get_value("Account", frm.doc.account, [
+			"account_currency",
+			"company",
+		]);
+
+		frm.set_query("bank_fee_account", (doc) => {
+			return {
+				filters: {
+					root_type: "Expense",
+					account_currency: currency,
+					company: company,
+				},
+			};
+		});
+	},
+});

banking/custom_fields.py

@@ -87,4 +87,14 @@ def get_custom_fields():
 				insert_after="transaction_id",
 			),
 		],
+		"Bank Account": [
+			dict(
+				fieldname="bank_fee_account",
+				fieldtype="Link",
+				label=_("Bank Fee Account"),
+				options="Account",
+				depends_on="eval:doc.is_company_account && doc.account",
+				insert_after="account_subtype",
+			),
+		],
 	}

banking/exceptions.py

@@ -0,0 +1,10 @@
+# Copyright (c) 2025, ALYF GmbH and Contributors
+# See license.txt
+
+from frappe.exceptions import ValidationError
+
+
+class CurrencyMismatchError(ValidationError):
+	"""Raised when two accounts unexpectedly have different currencies."""
+
+	pass

banking/hooks.py

@@ -34,6 +34,7 @@
 	"Employee": "custom/employee.js",
 	"Supplier": "custom/supplier.js",
 	"Bank Reconciliation Tool": "custom/bank_reconciliation_tool.js",
+	"Bank Account": "custom/bank_account.js",
 }
 doctype_list_js = {"Purchase Invoice": "custom/purchase_invoice_list.js"}
 # doctype_tree_js = {"doctype" : "public/js/doctype_tree.js"}
@@ -108,9 +109,13 @@
 doc_events = {
 	"Bank Transaction": {
 		"on_update_after_submit": "banking.overrides.bank_transaction.on_update_after_submit",
+		"before_validate": "banking.overrides.bank_transaction.before_validate",
+		"before_submit": "banking.overrides.bank_transaction.before_submit",
+		"on_cancel": "banking.overrides.bank_transaction.on_cancel",
 	},
 	"Bank Account": {
 		"before_validate": "banking.overrides.bank_account.before_validate",
+		"validate": "banking.overrides.bank_account.validate",
 	},
 	"Employee": {
 		"validate": "banking.custom.employee.validate",

banking/klarna_kosma_integration/doctype/bank_reconciliation_rule/bank_reconciliation_rule.js

@@ -0,0 +1,69 @@
+// Copyright (c) 2025, ALYF GmbH and contributors
+// For license information, please see license.txt
+
+frappe.ui.form.on("Bank Reconciliation Rule", {
+	onload: function (frm) {
+		frm.trigger("render_bt_filters");
+	},
+	refresh(frm) {
+		frm.trigger("set_target_account_query");
+	},
+	bank_account(frm) {
+		frm.trigger("set_target_account_query");
+	},
+	async set_target_account_query(frm) {
+		if (!frm.doc.bank_account) {
+			return;
+		}
+
+		const {
+			message: { account },
+		} = await frappe.db.get_value(
+			"Bank Account",
+			frm.doc.bank_account,
+			"account"
+		);
+
+		const {
+			message: { account_currency: currency, company: company },
+		} = await frappe.db.get_value("Account", account, [
+			"account_currency",
+			"company",
+		]);
+
+		frm.set_query("target_account", () => ({
+			filters: {
+				account_currency: currency,
+				company: company,
+			},
+		}));
+	},
+	render_bt_filters(frm) {
+		const parent = frm.fields_dict.filter_area.$wrapper;
+		parent.empty();
+
+		const filters =
+			frm.doc.filters && frm.doc.filters !== "[]"
+				? JSON.parse(frm.doc.filters)
+				: [];
+
+		frappe.model.with_doctype("Bank Transaction", () => {
+			const filter_group = new frappe.ui.FilterGroup({
+				parent: parent,
+				doctype: "Bank Transaction",
+				on_change: () => {
+					frm.set_value("filters", JSON.stringify(filter_group.get_filters()));
+				},
+			});
+
+			filter_group.add_filters_to_filter_group(filters);
+
+			if (frm.doc.docstatus === 1) {
+				parent.find(".filter-action-buttons").remove();
+				parent.find(".divider").remove();
+				parent.find(".remove-filter").remove();
+				parent.find(".form-control").prop("disabled", true);
+			}
+		});
+	},
+});

banking/klarna_kosma_integration/doctype/bank_reconciliation_rule/bank_reconciliation_rule.json

@@ -0,0 +1,135 @@
+{
+ "actions": [],
+ "creation": "2025-10-23 13:00:49.226504",
+ "doctype": "DocType",
+ "engine": "InnoDB",
+ "field_order": [
+  "account_settings_section",
+  "bank_account",
+  "target_account",
+  "disabled",
+  "filters_section",
+  "filter_description",
+  "filters",
+  "filter_area",
+  "amended_from"
+ ],
+ "fields": [
+  {
+   "fieldname": "bank_account",
+   "fieldtype": "Link",
+   "in_list_view": 1,
+   "label": "Bank Account",
+   "link_filters": "[[\"Bank Account\",\"is_company_account\",\"=\",1],[\"Bank Account\",\"account\",\"is\",\"set\"]]",
+   "options": "Bank Account",
+   "reqd": 1
+  },
+  {
+   "fieldname": "account_settings_section",
+   "fieldtype": "Section Break",
+   "label": "Account Settings"
+  },
+  {
+   "fieldname": "target_account",
+   "fieldtype": "Link",
+   "in_list_view": 1,
+   "label": "Target Account",
+   "options": "Account",
+   "reqd": 1
+  },
+  {
+   "fieldname": "filters_section",
+   "fieldtype": "Section Break",
+   "label": "Filters"
+  },
+  {
+   "fieldname": "filters",
+   "fieldtype": "Code",
+   "hidden": 1,
+   "label": "Filters",
+   "options": "JSON",
+   "read_only": 1
+  },
+  {
+   "fieldname": "filter_area",
+   "fieldtype": "HTML"
+  },
+  {
+   "fieldname": "filter_description",
+   "fieldtype": "HTML",
+   "options": "A <b>Journal Entry</b> is created automatically, when a submitted <b>Bank Transaction</b> matches these filters.<br>Please define set these filters as strictly as possible to avoid accounting errors.<br><br>"
+  },
+  {
+   "fieldname": "amended_from",
+   "fieldtype": "Link",
+   "label": "Amended From",
+   "no_copy": 1,
+   "options": "Bank Reconciliation Rule",
+   "print_hide": 1,
+   "read_only": 1,
+   "search_index": 1
+  },
+  {
+   "allow_on_submit": 1,
+   "default": "0",
+   "fieldname": "disabled",
+   "fieldtype": "Check",
+   "label": "Disabled"
+  }
+ ],
+ "grid_page_length": 50,
+ "index_web_pages_for_search": 1,
+ "is_submittable": 1,
+ "links": [],
+ "modified": "2026-01-27 21:55:21.191776",
+ "modified_by": "Administrator",
+ "module": "Klarna Kosma Integration",
+ "name": "Bank Reconciliation Rule",
+ "owner": "Administrator",
+ "permissions": [
+  {
+   "amend": 1,
+   "cancel": 1,
+   "create": 1,
+   "delete": 1,
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "System Manager",
+   "share": 1,
+   "submit": 1,
+   "write": 1
+  },
+  {
+   "cancel": 1,
+   "create": 1,
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "Accounts Manager",
+   "share": 1,
+   "submit": 1,
+   "write": 1
+  },
+  {
+   "create": 1,
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "Accounts User",
+   "share": 1,
+   "write": 1
+  }
+ ],
+ "row_format": "Dynamic",
+ "rows_threshold_for_grid_search": 20,
+ "sort_field": "modified",
+ "sort_order": "DESC",
+ "states": []
+}

banking/klarna_kosma_integration/doctype/bank_reconciliation_rule/bank_reconciliation_rule.py

@@ -0,0 +1,49 @@
+# Copyright (c) 2025, ALYF GmbH and contributors
+# For license information, please see license.txt
+
+import frappe
+from frappe import _
+from frappe.exceptions import ValidationError
+from frappe.model.document import Document
+
+from banking.exceptions import CurrencyMismatchError
+
+
+class NoFiltersError(ValidationError):
+	pass
+
+
+class BankReconciliationRule(Document):
+	# begin: auto-generated types
+	# This code is auto-generated. Do not modify anything in this block.
+
+	from typing import TYPE_CHECKING
+
+	if TYPE_CHECKING:
+		from frappe.types import DF
+
+		amended_from: DF.Link | None
+		bank_account: DF.Link
+		disabled: DF.Check
+		filters: DF.Code | None
+		target_account: DF.Link
+
+	# end: auto-generated types
+	def validate(self):
+		self.validate_account_currencies()
+		self.validate_filters()
+
+	def validate_account_currencies(self):
+		bank_account = frappe.db.get_value("Bank Account", self.bank_account, "account")
+		bank_account_currency = frappe.db.get_value("Account", bank_account, "account_currency")
+		target_account_currency = frappe.db.get_value("Account", self.target_account, "account_currency")
+
+		if bank_account_currency != target_account_currency:
+			frappe.throw(
+				_("Bank Account and Target Account need to be in the same currency!"), CurrencyMismatchError
+			)
+
+	def validate_filters(self):
+		# self.filters is a code field with json, so it has "[]" when empty
+		if not self.filters or len(self.filters) <= 2:
+			frappe.throw(_("Please define at least one filter!"), NoFiltersError)

banking/klarna_kosma_integration/doctype/bank_reconciliation_rule/bank_reconciliation_rule_list.js

@@ -0,0 +1,23 @@
+// Copyright (c) 2025, ALYF GmbH and contributors
+// For license information, please see license.txt
+
+frappe.listview_settings["Bank Reconciliation Rule"] = {
+	add_fields: ["docstatus", "disabled"],
+	has_indicator_for_draft: true,
+
+	get_indicator: function (doc) {
+		// Submitted documents
+		if (doc.docstatus === 1) {
+			if (doc.disabled === 1) {
+				return [__("Disabled"), "orange", "disabled,=,1"];
+			} else {
+				return [__("Active"), "green", "docstatus,=,1"];
+			}
+		}
+
+		// Draft documents
+		if (doc.docstatus === 0) {
+			return [__("Draft"), "blue", "docstatus,=,0"];
+		}
+	},
+};