chore: move custom fields and property setters into app#292
Open
MarcCon wants to merge 8 commits intoversion-15-hotfixfrom
Open
chore: move custom fields and property setters into app#292MarcCon wants to merge 8 commits intoversion-15-hotfixfrom
MarcCon wants to merge 8 commits intoversion-15-hotfixfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors custom field and property setter configurations from JSON files into Python code, following the erpnext_germany schema pattern. The changes improve maintainability by centralizing customization logic in executable Python files rather than static JSON configurations.
Changes:
- Created
custom_fields.pyandproperty_setters.pyto programmatically define customizations - Updated
install.pyto apply customizations from the new Python modules - Added
uninstall.pyfor cleanup operations - Removed legacy JSON configuration files from multiple modules
Reviewed changes
Copilot reviewed 29 out of 39 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| landa/landa_stock/custom/*.json | Removed JSON files for Item, Item Attribute, Item Barcode, Item Price, Price List, Packed Item, Delivery Note, and Delivery Note Item customizations |
| landa/landa_sales/custom/*.json | Removed JSON files for Sales Order, Sales Order Item, Sales Invoice Item, Payment Entry, Territory, and Sales Taxes and Charges Template customizations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
TODO: incorporate changes from #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves custom fields and property setters into the app following the erpnext_germany schema.
Changes:
Additional: The "field_order" property setter is not part of
doctype_propertiesand requires a fallback. (see /install.py:L129)