Skip to content

feat(Absence Plan): implement DocType + functionality (addition to Leave Application) (DRC-148)#48

Merged
PatrickDEissler merged 26 commits intoversion-15from
drc-148-2
Feb 3, 2026
Merged

feat(Absence Plan): implement DocType + functionality (addition to Leave Application) (DRC-148)#48
PatrickDEissler merged 26 commits intoversion-15from
drc-148-2

Conversation

@PatrickDEissler
Copy link
Copy Markdown
Collaborator

@PatrickDEissler PatrickDEissler commented Feb 2, 2026

Documentation:
https://github.com/alyf-de/time_capture/wiki/6)-Urlaube-&-andere-Abwesenheiten#absence-plan-abwesenheitsplan

Use cases:

  • weekly off (outside holiday list)
  • Employees that dont do Time Captures
  • educational leaves
  • ...

TODO:

  • Verwendung: Time Capture/ Attendance (inkl. metrics)
  • Cancellation process -> 1) If from_date not in future: throw; 2) Alternative: Delete rows, ...
  • Duplicate Warning error
  • Add notes/descriptions: 1) Not for the past; 2) Timespan vs. Weekly Off; 3) Submit; 4) Cancellation; 5) No Leave Ledger Entries!
  • Refactor
  • Test
  • Translations
  • Document
  • Ship

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements an "Absence Plan" DocType as an addition to the Leave Application system for managing planned employee absences that don't consume leave allocation. The feature integrates with the Time Capture and Attendance modules to automatically create attendance records for planned absence dates.

Changes:

  • Introduces Absence Plan and Absence Plan Date DocTypes with approval workflow
  • Adds automatic attendance creation for approved absence plans
  • Updates attendance metrics calculation to support absence plans alongside leave applications

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
absence_plan.py Core business logic including validation, duplicate prevention, notifications, and bulk date insertion
absence_plan.json Main DocType definition with fields for employee, leave type, dates, and approval workflow
absence_plan.js Client-side form logic with bulk insert dialog and delete future dates button
absence_plan_list.js List view indicator configuration for different statuses
absence_plan_date.py Child table document class (currently empty stub)
absence_plan_date.json Child table definition with date, weekday, and reason fields
time_capture.py Integration logic to create attendance records from approved absence plans
attendance.py Updated metrics calculation to handle absence plan leave types
custom_fields.py Adds custom fields to Attendance for linking to absence plans
patches.txt Migration patch timestamp update
locale files Translation strings for German and English
test_absence_plan.py Empty test class placeholder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PatrickDEissler PatrickDEissler marked this pull request as ready for review February 3, 2026 11:31
@PatrickDEissler PatrickDEissler merged commit 4727527 into version-15 Feb 3, 2026
5 checks passed
@PatrickDEissler PatrickDEissler deleted the drc-148-2 branch February 3, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants