Skip to content

Clean History#1

Open
ibamadd wants to merge 1 commit intoamadib:masterfrom
ibamadd:expermenting
Open

Clean History#1
ibamadd wants to merge 1 commit intoamadib:masterfrom
ibamadd:expermenting

Conversation

@ibamadd
Copy link

@ibamadd ibamadd commented Feb 25, 2015

Finalizing Solution

  • Removed loop for edge condition. Felt better to guarantee O(n) than randomness.
  • Added log4j support replacing sysout, created README, fixed edge case.
  • Added documentation and comments
  • Refactored method names
  • Cleaned up output
  • Simplified random generator
  • Exception on shuffling an empty deck
  • Turned off logging

randomness.

Finalizing Solution
* Added log4j support replacing sysout, created README, fixed edge case.
* Added documentation and comments
* Refactored method names
* Cleaned up output
* Simplified random generator
* Exception on shuffling an empty deck
* Turned off logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant