Skip to content

rapids-5129#1

Open
amahussein wants to merge 8 commits intobranch-22.06from
rapids-5129
Open

rapids-5129#1
amahussein wants to merge 8 commits intobranch-22.06from
rapids-5129

Conversation

@amahussein
Copy link
Copy Markdown
Owner

Draft PR to share progress integrating Rapids with Spark-History-Server

@amahussein
Copy link
Copy Markdown
Owner Author

This is just a hack with minimum changes to the Profiler tool.

  • When the Rapids-Tab gets loaded, a REST call pull the logLines and initialize a new AppInfo (see code-block)
  • to avoid making changes to the Rapids tool, I created RapidsAppInfoLogProcessor which extends ApplicationInfo. The new class was created to separate between the initialization of the instance and the processing phase.
  • Currently, the log will be processed everytime the tab is loaded.
  • Compare mode is not supported yet.

ToDo:

  • Initialize the EventProcessor in the Plugin initialization. This will allow the events to be processed during the replay of the log
  • the above step requires some modifications in both ApplicationInfo and EventsProcessor to enable initialization of the EventProcessor before an App gets created.
  • Accessing the output of the profile inside the HTML was not very trivial. ApplicationSummaryInfo is not friendly to read the values back. We will need to have a common interface Renderer that will support both txtFormat and Html/JS code generation
  • The output of the profiler needs to be saved to the SHS store. This will guarantee that the state of the profiling gets saved correctly, and that the data will be shared across the pages.
  • Profiler currently reads the arguments from command line. We can switch to look into getting the information from the configurations passed to the SHS.

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein
Copy link
Copy Markdown
Owner Author

Screenshot-2022-04-06 09-44-39


Below is the UI after adding JobInfo. Note that the empty columns are due to Started/Completed not profiled by the PRofiler tool yet.
AppIndex column is hidden. I will only enable it in the compare mode.
For JobInfo table, I explored grouping rows together. For example, instead of displaying each stage like [stage1, stage2] (which is the way SparkUI displays them). In this version, I display each stageID in a separate row.
There are lots of fancier way to display "grouping" but I did this simple form for a demo purpose.

Screenshot-from-2022-04-06-13-45-26

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein
Copy link
Copy Markdown
Owner Author

The compare table lists all the tables

Screenshot-from-2022-04-07-11-57-34


The results are displayed in the results page

Screenshot-from-2022-04-07-11-58-25

amahussein pushed a commit that referenced this pull request May 10, 2022
* Qualification tool: Parsing supported execs

Signed-off-by: Niranjan Artal <nartal@nvidia.com>

* addressed review comments

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
amahussein pushed a commit that referenced this pull request Dec 18, 2023
… targets. (NVIDIA#9615)

* Bloop updates - require JDK11 in buildall + docs, build bloop for all targets.

Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>

* Address PR comments.

Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>

* Add a bloopInstall profile (#1)

* Add bloopInstall profile

Signed-off-by: Gera Shegalov <gera@apache.org>

* Add bloopInstall profile

Fixes NVIDIA#9621

Signed-off-by: Gera Shegalov <gera@apache.org>

* add comment for install in scala2.13

Signed-off-by: Gera Shegalov <gera@apache.org>

* simplify

Signed-off-by: Gera Shegalov <gera@apache.org>

* undo unrelated

Signed-off-by: Gera Shegalov <gera@apache.org>

* Apply suggestions from code review

Co-authored-by: PhilDakin <phil.dakin.1@gmail.com>

* review 1

Signed-off-by: Gera Shegalov <gera@apache.org>

* Configurable bloopInstall phase

Signed-off-by: Gera Shegalov <gera@apache.org>

* move bloop config dir to execution conf

Signed-off-by: Gera Shegalov <gera@apache.org>

---------

Signed-off-by: Gera Shegalov <gera@apache.org>
Co-authored-by: PhilDakin <phil.dakin.1@gmail.com>

* Propagate bloopInstall profile changes, make config directory overridable from command line.

Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>

* Cleanup.

Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>

---------

Signed-off-by: Phil Dakin <phil.dakin.1@gmail.com>
Signed-off-by: Gera Shegalov <gera@apache.org>
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant