Closed
Conversation
Work in progress
Need to add partial derivative evaluator
To account for two way coupling between pipe and overland flow (need to test the new capability)
Since it does not depend on the pipe water depth but on the pipe pressure head
With new options for two way coupling between pipe and sw
According to Table 3 in Rubinato et al. "Experimental calibration and validation of sewer/surface flow exchange equations in steady and unsteady flow conditions"
…for one manhole; also see working ex coupled_surface_pipe_network_mild_incline.xml in ats-regression-test
…und results on multiple manholes
…/urban_storm_drains
…acomo/urban_storm_drains
…m:amanzi/ats into merge_w_master_giacomo/urban_storm_drains
This was referenced Apr 3, 2024
Author
|
Reopened here: #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a pipe drain evaluator modeling the flow of water through manholes between an overland flow model and an underground pipe network model. This PR is the companion of amanzi/amanzi#823