Fix bugs for set_time function in subcycling#336
Open
levuvietphong wants to merge 1 commit intomasterfrom
Open
Fix bugs for set_time function in subcycling#336levuvietphong wants to merge 1 commit intomasterfrom
levuvietphong wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect handling of
set_timefor theCURRENTandNEXTtags.Without set_time, the model always assumed a start time of 0. When a simulation started at a nonzero time, this resulted in t_this < t_current and caused the model to stop.
The fix ensures set_time respects the configured start time, preventing invalid time during interpolation.