Make all created UI widgets aware of display scaling. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
EDIT: Fixed by the commit below. |
Without this, and scaling set to 200%, back/forward and media key indicators were huge, misaligned, and with their contents mostly outside of their circle, and the window switch list was tiny.
Some windows (e.g. Discord and VS Code) apply the display scaling strangely, and they also don't care which display they are on (only using the scaling of the primary monitor). This caused misaligned back/forward indicators even in single-monitor scenarios. To fix this, all indicators are now drawn in the global context (Main.layoutManager.uiGroup) instead, actually removing some complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, and scaling set to 200%, back/forward and media key indicators were huge, misaligned, and with their contents mostly outside of their circle, and the window switch list was tiny.
Not sure if this is the cleanest implementation, but the different alignment calculations and other factors made it hard to make a common solution in one place.