[WIP] Support for hidden databases (Rails 7)#89
Open
schmijos wants to merge 1 commit intoamatsuda:masterfrom
Open
[WIP] Support for hidden databases (Rails 7)#89schmijos wants to merge 1 commit intoamatsuda:masterfrom
schmijos wants to merge 1 commit intoamatsuda:masterfrom
Conversation
schmijos
changed the title
schmijos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveRecord::Base.configurations.configs_for(Rails 7.0, Rails 7.1) knows two kind of hidden database configurations:replica: trueanddatabase_tasks: false.It was unexpected for me to find out that
DatabaseRewinderdoesn't consider the readonly database I have in my project. Because when testing I still insert fakes and expect them to be rewinded.I added two tests to the suite to pinpoint the problem. But I'm not sure what a good solution would actually be. Maybe a hint in the docs about how
database_tasks: falsewill affect your upgrade path to Rails 7 when usingDatabaseRewinderwould be enough?