fix: Update Bell pair notebook for Ankaa-3 frame name and waveform API#855
Merged
virajvchaudhari merged 1 commit intoamazon-braket:mainfrom Mar 23, 2026
Merged
Conversation
Cell 20 of 3_Bell_pair_with_pulses_Rigetti.ipynb has been broken since PR amazon-braket#683 (Feb 2025) which migrated pulse notebooks to Ankaa-3. Two issues: - Hardcoded frame name 'Transmon_109_flux_tx_c' does not exist on Ankaa-3 for qubit pair (13, 20). Replaced with 'Transmon_13_flux_tx_iswap_20'. - Ankaa-3 uses ErfSquareWaveform (parametric) instead of ArbitraryWaveform, so .amplitudes does not exist. Replaced len(wfm.amplitudes) with wfm.length / dt.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sesmart
approved these changes
Mar 21, 2026
rmshaffer
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Cell 20 of 3_Bell_pair_with_pulses_Rigetti.ipynb has been broken since PR #683 (Feb 2025) which migrated pulse notebooks to Ankaa-3.
Description of changes:
Two issues:
Hardcoded frame name 'Transmon_109_flux_tx_c' does not exist on Ankaa-3 for qubit pair (13, 20). Replaced with 'Transmon_13_flux_tx_iswap_20'.
Ankaa-3 uses ErfSquareWaveform (parametric) instead of ArbitraryWaveform, so .amplitudes does not exist. Replaced len(wfm.amplitudes) with wfm.length / dt.
Will add this back to test suite in the follow-up PRs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.