Skip to content

feat: In-place modifications of waveforms#726

Open
jcjaskula-aws wants to merge 21 commits intomainfrom
jcjaskula-aws/add_in_place_modifications
Open

feat: In-place modifications of waveforms#726
jcjaskula-aws wants to merge 21 commits intomainfrom
jcjaskula-aws/add_in_place_modifications

Conversation

@jcjaskula-aws
Copy link
Copy Markdown
Contributor

@jcjaskula-aws jcjaskula-aws commented Oct 5, 2023

Issue #, if available:
Circuits and PulseSequences with waveforms cannot be reliably modified.

Description of changes:
We have implemented setters for every waveform parameters which update the Braket waveform and the OQPy waveform variables.

Testing done:
Added a unit test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Base automatically changed from jcjaskula-aws/fix_oqpy_upgrade to main February 5, 2024 21:46
@jcjaskula-aws jcjaskula-aws force-pushed the jcjaskula-aws/add_in_place_modifications branch from 09572f4 to b75bb74 Compare March 18, 2024 21:58
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2fc6cfd) to head (4e1688d).

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #726    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          162       162            
  Lines        10508     10620   +112     
  Branches      1310      1314     +4     
==========================================
+ Hits         10508     10620   +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jcjaskula-aws jcjaskula-aws marked this pull request as ready for review March 24, 2024 03:35
@jcjaskula-aws jcjaskula-aws requested a review from a team as a code owner March 24, 2024 03:35
@speller26 speller26 self-requested a review July 24, 2025 17:38
@speller26 speller26 changed the title Add in-place modifications of waveforms feat: Add in-place modifications of waveforms Dec 17, 2025
@speller26 speller26 changed the title feat: Add in-place modifications of waveforms feat: In-place modifications of waveforms Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants