Open
Conversation
This reverts commit a8fd788.
Replace all getString/getJSONObject calls with optString/optJSONObject in WebSocketManager to prevent crashes when optional fields are missing from WebSocket payloads. Bump version to 2.0.11. Includes 23 unit tests covering all handler methods with complete and missing field scenarios. Fixes: #99 Related: P382365182
xiajohn
approved these changes
Mar 3, 2026
xiajon
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
This PR restores the previously reverted DescribeView feature and fixes the WebSocket crash caused by force-unwrapping
optional JSON fields in WebSocket message handlers.
Background
The DescribeView feature (PR #96) was reverted in PR #98 due to a reported crash (JSONException: No value for MessageId).
Investigation confirmed that:
getString() (which throws) instead of optString() (which returns a default)
Changes
1. Restore DescribeView API support
2. Fix: Loosen message property requirements in WebSocket handler
3. Version bump to 2.0.11
Testing
total, 0 failures)
resolves it