Skip to content

Address issues with debug allocator, and utf-8 escape sequences#367

Merged
nirosys merged 2 commits intoamazon-ion:masterfrom
nirosys:rgiliam/debug_and_utf_fixes
Nov 7, 2025
Merged

Address issues with debug allocator, and utf-8 escape sequences#367
nirosys merged 2 commits intoamazon-ion:masterfrom
nirosys:rgiliam/debug_and_utf_fixes

Conversation

@nirosys
Copy link
Contributor

@nirosys nirosys commented Nov 6, 2025

Issue #, if available:

Description of changes:
This PR addresses 2 issues:

  • A potential integer overflow when using the debug allocator.
  • Potential for uninitialized memory to be included as part of a UTF-8 escape sequence.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 6, 2025

Looks like libasan is no longer installed by default, but this will be addressed with #366. Once it is merged, we can merge and re-run tests.

@nirosys nirosys requested a review from tgregg November 7, 2025 01:35
tgregg
tgregg previously approved these changes Nov 7, 2025
Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to cherry-pick the libasan/libubsan changes from #366. I think that one needs to snowball a bit and I don't want to block this one.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 7, 2025

It feels like you can never know when a small change is going to wipe out an approval.. :/

@nirosys nirosys requested a review from tgregg November 7, 2025 07:56
@nirosys nirosys merged commit 49c53b5 into amazon-ion:master Nov 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants