Use GitHub runner built-in Rust support#210
Closed
jobarr-amzn wants to merge 1 commit intoamazon-ion:mainfrom
Closed
Use GitHub runner built-in Rust support#210jobarr-amzn wants to merge 1 commit intoamazon-ion:mainfrom
jobarr-amzn wants to merge 1 commit intoamazon-ion:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions-rs/toolchain is unmaintained, see: actions-rs/toolchain#216
The GitHub docs recommend using the built-in
rustupavailable in GitHub runners: https://docs.github.com/en/actions/tutorials/build-and-test-code/rustPerhaps we want to use dtolnay/rust-toolchain instead?
We may want to cache dependencies? See:
This PR is meant to at least start a conversation about what we want to do with CI builds going forward.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.